association navigability code seems to be out of sync with UML 2.1.2

Problem is in source:gaphor/trunk/gaphor/diagram/classes/association.py just before line 437:

            # if navigable
            if isinstance(opposite.type, UML.Class):
                if subject.class_:
                    del subject.class_
            elif isinstance(opposite.type, UML.Interface):
                if subject.interface_:
                    del subject.interface_
            else:
                assert 0, 'Should never be reached'

No case for the Use Case :).

UseCase? is a classifier, therefore UseCase?.classifier attribute should be deleted/set.

but Property.interface_ and Property.class_ override Property.classifier, isn't it?

we probably just should set Property.classifier and get rid of above conditionals, then Property.{class_,interface_} will be set automatically, isn't it?

should navigability of an association end be possible to change in case of just classifier?

few notes

• uml2.gaphor misses Association.navigableOwnedEnd in classes diagram
• uml2.gaphor interface diagram, there is Property.interface_ diagram, it is not defined in UML specification (UML 2.1.2, page 38)
• Property misses Property::isNavigable() : Boolean query (UML 2.1.2, page 126)

answering my last question, Property::isNavigable checks if classifier is empty, so it seems that it should be possible to change navigability of a an association end in case of any classifier, but

• how to change navigability in case of UseCase?? setting a Property.classifier gives us

    File "./gaphor/UML/properties.py", line 56, in __set__
      self._set(obj, value)
    File "./gaphor/UML/properties.py", line 504, in _set
      raise AttributeError, 'Can not set values on a union'
  AttributeError: Can not set values on a union
  

• how to change navigability in case of Interface as there should be no Property.interface_ attribute?

I noticed some other things that have changed since UML 2.0 and 2.1.2 (e.g. Implementation is renamed to InterfaceRealization).

Property.interface_ should be known as Property.interface in the UML model (or have they changed that one too?).

We should probably do some updating of the model. But it may be best to save that for 0.14.0. I've created a ticket (#109) for that purpose.

Property.classifier is defined as derived union. From gaphor/UML/uml2.py:

Property.classifier = derivedunion('classifier', 0, 1, Property.useCase, Property.actor, Property.interface_, Property.datatype, Property.class_)

Property.interface (Property.inteface_) does not exist in UML anymore it seems (page 38, Interfaces diagram).

I would like to fix classifiers' associations before for gaphor 0.13.0.

Replying to arj..@yirdis.nl: ...

Property.classifier is defined as derived union. From gaphor/UML/uml2.py: {{{ Property.classifier = derivedunion('classifier', 0, 1, Property.useCase, Property.actor, Property.interface_, Property.datatype, Property.class_) }}}

I cannot spot any of Property.{actor,interface_,useCase} attributes to be defined in UML specification. Property.{class_,datatype} are still there.

Replying to wrobe..@pld-linux.org:

I cannot spot any of Property.{actor,interface_,useCase} attributes to be defined in UML specification. Property.{class_,datatype} are still there.

They're probably 2.0 stuff, removed in 2.1 or something. They're in the the model anyway:

Property.useCase = association('useCase', UseCase, upper=1, opposite='ownedAttribute')
Property.interface_ = association('interface_', Interface, upper=1, opposite='ownedAttribute')
Property.actor = association('actor', Actor, upper=1, opposite='ownedAttribute')
Actor.ownedAttribute = association('ownedAttribute', Property, composite=True, opposite='actor')

I think it's best to stick to the current model as is and update it for the next release (this will have some serious impact, most notably in the storage module).

... so much for a "standard" ;(

Replying to arj..@yirdis.nl:

Replying to wrobe..@pld-linux.org:

I cannot spot any of Property.{actor,interface_,useCase} attributes to be defined in UML specification. Property.{class_,datatype} are still there.

They're probably 2.0 stuff, removed in 2.1 or something. They're in the the model anyway: {{{ Property.useCase = association('useCase', UseCase?, upper=1, opposite='ownedAttribute') Property.interface_ = association('interface_', Interface, upper=1, opposite='ownedAttribute') Property.actor = association('actor', Actor, upper=1, opposite='ownedAttribute') Actor.ownedAttribute = association('ownedAttribute', Property, composite=True, opposite='actor') }}} I think it's best to stick to the current model as is and update it for the next release (this will have some serious impact, most notably in the storage module). ... so much for a "standard" ;(

well, everything is fluid :) probably we should use Association.navigableOwnedEnd, now. but i will use Property.{actor,useCase} to fix this bug.

fixed in changesets [2270] and [2271]