Ticket #76 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Toolbar-item "Open" fails with TypeError

Reported by: blacksk..@gmail.com Assigned to: arj..@yirdis.nl
Priority: major Milestone: Gaphor 0.13.0
Component: Gaphor Version:
Keywords: _open_dialog open action TypeError Cc:

Description

I installed Gaphor (12.2) on Ubuntu (Gutsy 7.10, latest updates installed) using easy_install. It failed to open a FileChooserDialog?, raising following error:

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/gaphor-0.12.2-py2.5.egg/gaphor/action.py", line 153, in _action_activate
    method()
TypeError: _open_dialog() takes exactly 2 arguments (1 given)


The real error is not in _action_activate though. It's in gaphor/services/filemanager.py at line 217, the @action line before the _open_dialog method in FileManager?. With line 217 removed, everything works as expected.
It's a duplicate (and wrong) definition of the action "file-open". The open-method is also (correctly) declared as the action file-open. On gutsy, the wrong method is invoked, where the right method was invoked on feisty (which is why I didn't had this problem earlier).

Thanks for the nice tool!
Thomas

Attachments

Change History

09/11/07 05:49:41 changed by arj..@yirdis.nl

  • status changed from new to closed.
  • resolution set to fixed.

(In [2117]) Removed false declaration of file-open action. Fixes #76.


Add/Change #76 (Toolbar-item "Open" fails with TypeError)




Action